feat: github app authentication and repo standardization #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That should have been run against python 3.10, not python 3.1. 😕 Re-running. UPDATE: Versions needed to be in string format |
jmeridth
force-pushed
the
jm-github-app-auth-and-repo-standardization
branch
2 times, most recently
from
3ef62ed
to
9f876be
Compare
- [x] setting minimum python to 3.10 (allows usage of unions on types) - [x] add ability for users to authenticate with GitHub App Installation - [x] standardize repo - [x] Makefile - [x] Linting - [x] same workflows as other OSPO GitHub Actions - [x] add @jmeridth to CODEOWNERS - [x] update .env-example - [x] update README - [x] standardize all workflows (including examples) permissions - [x] contents: read by default - [x] more details in jobs - [x] add tests - [x] coverage to 60% for now, will get above 80% later - [x] pull request template Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm-github-app-auth-and-repo-standardization
branch
from
9f876be
to
c79601a
Compare
zkoppert
approved these changes
Apr 8, 2024
| FROM python:3.8-slim-buster | ||
| #checkov:skip=CKV_DOCKER_2 | ||
| #checkov:skip=CKV_DOCKER_3 | ||
| FROM python:3.12-slim |
There was a problem hiding this comment.
Since we are dropping support for 3.8, lets do a major version bump and note in the release notes that the breaking change is dropping python 3.8 support.
Co-authored-by: Zack Koppert <zkoppert@github.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
cm -> context_manager Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
This was referenced Apr 8, 2024
jmeridth
added a commit
that referenced
this pull request
Apr 8, 2024
Since we're about to do a major version release, need to update action.yml to v3. Should have been done in #43 - [x] update action.yml to v3 - [x] update dependencies Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
added a commit
that referenced
this pull request
Apr 8, 2024
I renamed the workflow from linter.yml to super-linter.yml in #43 Signed-off-by: jmeridth <jmeridth@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of this PR is necessary. Not my usual PR size.
No external changes from a user's perspective but a bit of an overhaul/refactor. I'd still say a minor release, not major. Unless we feel setting minimum python to 3.10. We are building the action with 3.12 now but test against 3.10+.
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking