Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use SHAs in GitHub Actions and pull_request_target for releases #76

Merged

Conversation

jmeridth
Copy link
Member

Pull Request

Proposed Changes

  • replace tags in GitHub Actions with SHAs (tags are movable, SHAs are not, more secure)
  • add pull_request_target to release GitHub Action so we have access to fork PR labels

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance or breaking

- [x] replace tags in GitHub Actions with SHAs (tags are movable, SHAs are not, more secure)
- [x] add pull_request_target to release GitHub Action so we have access to fork PR labels

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this May 21, 2024
@jmeridth jmeridth merged commit 2001c16 into main May 21, 2024
25 checks passed
@jmeridth jmeridth deleted the jm-github-action-shas-and-pull-request-target-for-releases branch May 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant