Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky MacOS test suite #58

Open
iansan5653 opened this issue Jul 19, 2022 · 1 comment
Open

Flaky MacOS test suite #58

iansan5653 opened this issue Jul 19, 2022 · 1 comment

Comments

@iansan5653
Copy link
Member

The CI test suite intermittently fails on MacOS due to what looks like a race condition:

npm ERR! code 1
npm ERR! path /Users/runner/work/combobox-nav/combobox-nav/node_modules/chromium
npm ERR! command failed
npm ERR! command sh -c node install.js
npm ERR! Step 1. Retrieving Chromium revision number
npm ERR! Step 2. Downloading Chromium revision 1025666
npm ERR! /Users/runner/work/combobox-nav/combobox-nav/node_modules/p-cancelable/index.js:48
npm ERR! 					throw new Error('The `onCancel` handler was attached after the promise settled.');
npm ERR! 					      ^
npm ERR! 
npm ERR! Error: The `onCancel` handler was attached after the promise settled.
npm ERR!     at onCancel (/Users/runner/work/combobox-nav/combobox-nav/node_modules/p-cancelable/index.js:48:12)
npm ERR!     at makeRequest (/Users/runner/work/combobox-nav/combobox-nav/node_modules/got/dist/source/as-promise/index.js:38:13)
npm ERR!     at Request.<anonymous> (/Users/runner/work/combobox-nav/combobox-nav/node_modules/got/dist/source/as-promise/index.js:143:17)
npm ERR!     at Object.onceWrapper (node:events:642:26)
npm ERR!     at Request.emit (node:events:527:28)
npm ERR!     at Timeout.retry (/Users/runner/work/combobox-nav/combobox-nav/node_modules/got/dist/source/core/index.js:1278:30)
npm ERR!     at listOnTimeout (node:internal/timers:55[9](https://github.com/github/combobox-nav/runs/7410232560?check_suite_focus=true#step:4:10):17)
npm ERR!     at processTimers (node:internal/timers:502:7)
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/runner/.npm/_logs/2022-07-19T[13](https://github.com/github/combobox-nav/runs/7410232560?check_suite_focus=true#step:4:14)_32_24_7[14](https://github.com/github/combobox-nav/runs/7410232560?check_suite_focus=true#step:4:15)Z-debug-0.log

This doesn't happen on Ubuntu/Windows.

@iansan5653
Copy link
Member Author

As an example, this run failed 3 times before passing:

Screenshot of the test suite results. There are three failures followed by one successful run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant