Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Update query for focusable elements #30

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Update query for focusable elements #30

merged 3 commits into from
Apr 5, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Apr 2, 2019 •
edited
Loading

Resolves #26.

References:

cc @bennypowers

@muan muan requested a review from a team April 2, 2019 21:32
mislav
mislav approved these changes Apr 3, 2019
View reviewed changes
index.js
@@ -141,9 +140,6 @@ class DetailsDialogElement extends HTMLElement {
static get CLOSE_SELECTOR() {
return CLOSE_SELECTOR
}
static get INPUT_SELECTOR() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this was part of the element's API? 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #11. I should've questioned it more. 😔

@muan muan merged commit 52cc333 into master Apr 5, 2019
@muan muan deleted the tabindex branch April 5, 2019 21:07
@muan muan restored the tabindex branch April 5, 2019 21:09
@muan muan deleted the tabindex branch April 5, 2019 21:09
@muan muan restored the tabindex branch April 5, 2019 21:10
@muan muan deleted the tabindex branch April 5, 2019 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgraham dgraham dgraham approved these changes

@mislav mislav mislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muan @mislav @dgraham