Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gems): add non-default gems to the gemspec #46

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

nobe4
Copy link
Contributor

@nobe4 nobe4 commented Sep 27, 2024

Starting in Ruby 3.5.0, the logger and ostruct will not be part of the default gem and will need to be manually vendored.

Example output with warnings:

/entitlements/vendor/gems/ruby/3.3.0/gems/concurrent-ruby-1.3.3/lib/concurrent-ruby/concurrent/concern/deprecation.rb:1: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
/entitlements/bin/deploy-entitlements:27: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.

Starting in Ruby 3.5.0, the `logger` and `ostruct` will not be part of
the default gem and will need to be manually vendored.

Example output with warnings:

```
/entitlements/vendor/gems/ruby/3.3.0/gems/concurrent-ruby-1.3.3/lib/concurrent-ruby/concurrent/concern/deprecation.rb:1: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
/entitlements/bin/deploy-entitlements:27: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
```
@nobe4 nobe4 merged commit 83843e8 into main Sep 27, 2024
17 checks passed
@nobe4 nobe4 deleted the add-non-default-gems branch September 27, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants