Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile #134

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update Dockerfile #134

merged 1 commit into from
Oct 30, 2024

Conversation

gracepark
Copy link
Contributor

We updated recently to node 22. The devcontainer that we're pulling should be 22 and not 0-22 as seen here:

https://mcr.microsoft.com/v2/devcontainers/javascript-node/tags/list

@gracepark gracepark requested a review from a team as a code owner October 30, 2024 18:01
jibrang
jibrang approved these changes Oct 30, 2024
View reviewed changes
Copy link

@jibrang jibrang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gracepark gracepark merged commit bb3706d into main Oct 30, 2024
5 checks passed
@gracepark gracepark deleted the gracepark-update-dockerfile-for-correct-version branch October 30, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibrang jibrang jibrang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gracepark @jibrang