Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move search functions and tests to their own files #407

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Oct 18, 2024

Pull Request

This pull request refactors the issue_metrics.py module by moving the search_issues and get_owners_and_repositories functions to a new search.py module. Additionally, it moves the corresponding unit tests to their own test file to follow the current style.

The purpose of doing this is to improve readability of issue_metrics.py by separating out the search specific functions.

Proposed Changes

  • Move search_issues and get_owners_and_repositories functions to search.py
  • Move corresponding unit tests to `test_search.py
  • Fix imports and pylint issues

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert zkoppert self-assigned this Oct 18, 2024
@zkoppert zkoppert marked this pull request as ready for review October 18, 2024 18:43
@zkoppert zkoppert merged commit 2150548 into main Oct 18, 2024
33 checks passed
@zkoppert zkoppert deleted the search-refactor branch October 18, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants