Skip to content

Commit

Permalink
bump liquid and redcarpet
Browse files Browse the repository at this point in the history
  • Loading branch information
@benbalter
benbalter committed Sep 11, 2013
1 parent 3a88bbc commit f09dd3e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions github-pages.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ Gem::Specification.new do |s|
s.add_dependency("RedCloth", "= 4.2.9")
s.add_dependency("jekyll", "= 1.1.2")
s.add_dependency("kramdown", "= 1.0.2")
s.add_dependency("liquid", "= 2.5.1")
s.add_dependency("liquid", "= 2.5.2")
s.add_dependency("maruku", "= 0.6.1")
s.add_dependency("rdiscount", "= 1.6.8")
s.add_dependency("redcarpet", "= 2.2.2")
s.add_dependency("redcarpet", "= 2.3.0")
end

7 comments on commit f09dd3e

@zerobase
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your information, Jekyll 1.1.2 and Liquid 2.5.2 caused an issue: Liquid doesn't render my partial · Issue #1519 · mojombo/jekyll.

This bug is already fixed with this patch: Merge pull request #1525 from zerobase/issue1519 · 5c23ae1 · mojombo/jekyll.

But on GitHub Pages, this issue still remains. In my website, Page Menu ("ページメニュー") is not rendered. This is the source: markdown.jp/_includes/sidenav.html at gh-pages · markdown-ja/markdown.jp.

@benbalter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh so. 1.1.2 and 2.5.1 or 1.2.0 and 2.5.2?

@zerobase
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these patterns:

  • Jekyll 1.1.2 and Liquid 2.5.1 -> Good.
  • Jekyll 1.2.0 and Liquid 2.5.1 -> Good.
  • Jekyll 1.1.2 and Liquid 2.5.2 -> Bad.
  • Jekyll 1.2.0 and Liquid 2.5.2 -> Bad.

@benbalter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jekyll 1.2.0 and Liquid 2.5.2 -> Bad.

/cc @parkr, jekyll/jekyll#1536

@benbalter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should really be =1.5.1 regardless then?

@zerobase
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think Liquid 2.5.1 is appropriate for now, whichever version of Jekyll you choose.

@parkr
Copy link
Contributor

@parkr parkr commented on f09dd3e Sep 12, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noooooooooooooooooooo!!! Darn you, Liquid.

Please sign in to comment.