Whitelist jekyll-spaceship for everyone #688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreytse
force-pushed
the
master
branch
2 times, most recently
from
b593699
to
75f8746
Compare
|
Hi @parkr Currently the CI keep building failed, since the
Thanks with regards |
|
Hi @parkr Now the building has passed, thanks a lot. Regards |
|
Any updates? I'm tracking this as a CRITICAL ACESSABILITY ISSUE for people in the development community who are visually disabled and use mermaidjs to communicate visual ideas. Not supporting this is actively excluding us. |
|
Any updates? It would make embedding media a lot easier too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitelist jekyll-spaceship for everyone.
But do not include as a runtime dependency because not everyone will find it useful.
Although it is very new to this world, it contains many potentially useful features for jekyll pages, which is also the biggest value and contribution of its birth to the open source community. Now it's also refered by Jekyll Docs.
Hope this can help everyone. Appreciate and thanks.