Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS optional-chained member expression. #467

Closed
wants to merge 3 commits into from
Closed

Fix JS optional-chained member expression. #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9af25b3
Fix JS optional-chained member expression.
Nov 19, 2024
cf773f4
Suggestion
hendrikvanantwerpen Dec 6, 2024
60681c3
Use field names instead of positions to match member expressions
hendrikvanantwerpen Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions languages/tree-sitter-stack-graphs-javascript/src/stack-graphs.tsg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3189,22 +3189,22 @@ inherit .containing_class_value
;; ##### Member Expressions

(member_expression
(_)@object . (_)@property)@member_expr
{

node member_push
node property_push
object:(_)@object
property:(_)@property
)@member_expr {
node member_push
node property_push

; scopes flow into object then back out
edge @object.before_scope -> @member_expr.before_scope
edge @member_expr.after_scope -> @object.after_scope

; value is a member projection on the value of the object ie. a push then push dot
attr (member_push) push_symbol = "GUARD:MEMBER"
attr (property_push) node_reference = @property
edge property_push -> member_push
edge @member_expr.value -> property_push
edge member_push -> @object.value
attr (member_push) push_symbol = "GUARD:MEMBER"
attr (property_push) node_reference = @property
edge property_push -> member_push
edge @member_expr.value -> property_push
edge member_push -> @object.value

; (member_expression) nodes can occur in patterns
node @member_expr.covalue
Expand Down
7 changes: 6 additions & 1 deletion languages/tree-sitter-stack-graphs-javascript/test/expressions/member_expression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,9 @@ let x = 1;
// Flow around

/**/ x;
// ^ defined: 1
// ^ defined: 1

// Optional chain

/**/ x?.foo
// ^ defined: 1
Loading