Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error codes from HDF5 libraries #6

Open
graeme-winter opened this issue May 24, 2024 · 1 comment
Open

Catch error codes from HDF5 libraries #6

graeme-winter opened this issue May 24, 2024 · 1 comment

Comments

@graeme-winter
Copy link

e.g.

ws448 ap :) $ imginfo -v -v /dls/mx-scratch/yqf46943/error-h5/20240429_BMS-0003_11_1_1_master.h5 > /tmp/out
HDF5-DIAG: Error detected in HDF5 (1.10.7) thread 1:
  #000: H5Dio.c line 198 in H5Dread(): can't read data
    major: Dataset
    minor: Read failed
  #001: H5Dio.c line 463 in H5D__read(): unable to set up type info
    major: Dataset
    minor: Unable to initialize object
  #002: H5Dio.c line 977 in H5D__typeinfo_init(): unable to convert between src and dest datatype
    major: Dataset
    minor: Feature is unsupported
  #003: H5T.c line 4680 in H5T_path_find(): can't find datatype conversion path
    major: Datatype
    minor: Can't get value
  #004: H5T.c line 4893 in H5T__path_find_real(): no appropriate function for conversion path
    major: Datatype
    minor: Unable to initialize object
HDF5-DIAG: Error detected in HDF5 (1.10.7) thread 1:
  #000: H5Dio.c line 198 in H5Dread(): can't read data
    major: Dataset
    minor: Read failed
  #001: H5Dio.c line 463 in H5D__read(): unable to set up type info
    major: Dataset
    minor: Unable to initialize object
  #002: H5Dio.c line 977 in H5D__typeinfo_init(): unable to convert between src and dest datatype
    major: Dataset
    minor: Feature is unsupported
  #003: H5T.c line 4680 in H5T_path_find(): can't find datatype conversion path
    major: Datatype
    minor: Can't get value
  #004: H5T.c line 4893 in H5T__path_find_real(): no appropriate function for conversion path
    major: Datatype
    minor: Unable to initialize object

however imginfo ran to completion though printed a warning that something was missing: feels like this should have been caught by imginfo

We are happy to look at this also

@CV-GPhL
Copy link
Collaborator

CV-GPhL commented May 24, 2024

Depending on the environment where it is run (in a test environment to check certain compliances versus within automatically triggered pipelines) a different behaviour might be considers: what constitutes a fatal error on one might not be one in the other.

Within a processing pipeline a user has options to override such issues. This is a crucial mechanism we use in autoPROC: there can be breaking changes in HDF5 datasets inbetween software releases that would stop all processing jobs if they become a fatal error, but either autoPROC recovers automatically (using other defaults etc) or allows users to provide a temporary fixup directly on the command-line.

Anyway, adding an option (--stop-on-error or such) that would trigger your suggested behaviour seems like a good idea, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants