Fix errors from type casting in UI (#141)

* Fix typo: `addTagManually`
gitploy-io · Oct 1, 2021 · ac2b0c1 · noahingh · Oct 2, 2021 · ac2b0c1
1 parent 247a4ed
commit ac2b0c1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/ui/src/components/ApproversSelect.tsx b/ui/src/components/ApproversSelect.tsx
@@ -32,9 +32,9 @@ export default function ApproversSelect(props: ApproversSelectProps): JSX.Elemen
     }, 800)
 
     const _onSelectCandidate = (id: string) => {
-        const candidate = props.candidates.find(c => c.id.toString() ===id)
+        const candidate = props.candidates.find(c => c.id === parseInt(id))
         if (candidate === undefined) {
-            return
+            throw new Error("The candidate is undefined.")
         }
 
         onSelectCandidate(candidate)

diff --git a/ui/src/redux/repoDeploy.tsx b/ui/src/redux/repoDeploy.tsx
@@ -224,7 +224,7 @@ export const addTagManually = createAsyncThunk<Tag, string, { state: {repoDeploy
         const { namespace, name } = getState().repoDeploy
 
         try {
-            const tag = await getTag(namespace, name, name)
+            const tag = await getTag(namespace, name, tagName)
             return tag
         } catch(e) {
             if (e instanceof HttpNotFoundError) {

diff --git a/ui/src/views/Deployment.tsx b/ui/src/views/Deployment.tsx
@@ -101,14 +101,14 @@ export default function DeploymentView(): JSX.Element {
     }
 
     const onSelectCandidate = (id: string) => {
-        const approval = approvals.find(a => a.user?.id.toString() === id) 
+        const approval = approvals.find(a => a.user?.id === parseInt(id)) 
 
         if (approval !== undefined) {
             dispatch(deleteApproval(approval))
             return
         }
 
-        const candidate = candidates.find(c => c.id.toString() === id)
+        const candidate = candidates.find(c => c.id === parseInt(id))
         if (candidate === undefined) {
             throw new Error("The candidate is not found")
         }