From e973f527f92a932e833167c57cb4d4eeb3103429 Mon Sep 17 00:00:00 2001
From: Eliah Kagan <degeneracypressure@gmail.com>
Date: Wed, 27 Sep 2023 05:06:59 -0400
Subject: [PATCH] Use some handy bash-isms in version check script

The script is nonportable to other shells already because of its
use of trap (and other features, such as implicit assumptions made
about echo, and the function keyword), which its hashbang already
clearly conveys.

This uses:

- $(<X) in place of $(cat X), to have the shell read the file
  directly rather than using cat.

- printf -v in one place to set a variable rather than printing.
  This eliminates a command substitution that was harder to read.
---
 check-version.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/check-version.sh b/check-version.sh
index 46aa56173..d4200bd20 100755
--- a/check-version.sh
+++ b/check-version.sh
@@ -12,7 +12,7 @@ readonly changes_path='doc/source/changes.rst'
 
 function get_latest_tag() {
     local config_opts
-    config_opts="$(printf ' -c versionsort.suffix=-%s' alpha beta pre rc RC)"
+    printf -v config_opts ' -c versionsort.suffix=-%s' alpha beta pre rc RC
     # shellcheck disable=SC2086  # Deliberately word-splitting the arguments.
     git $config_opts tag -l '[0-9]*' --sort=-v:refname | head -n1
 }
@@ -31,7 +31,7 @@ echo 'Checking that ALL changes are committed.'
 git status -s --ignore-submodules
 test -z "$(git status -s --ignore-submodules)"
 
-version_version="$(cat "$version_path")"
+version_version="$(<"$version_path")"
 changes_version="$(awk '/^[0-9]/ {print $0; exit}' "$changes_path")"
 latest_tag="$(get_latest_tag)"
 head_sha="$(git rev-parse HEAD)"