Add support for Python 3.13 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
cp313
branch
2 times, most recently
from
b5ca26c to
d5327e9
Compare
|
Thanks for contributing, and for the hint. |
Byron
approved these changes
Oct 9, 2024
EliahKagan
added a commit
to EliahKagan/smmap
that referenced
this pull request
Jan 2, 2025
This is analogous to the gitdb test workflow and `setup.py` were updated inhttps://github.com/gitpython-developers/gitdb/pull/114. 1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available. 2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap. 3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases. In particular, this change, due to (1), fixes the current CI failure for smmap observed in f31bfa3.
EliahKagan
added a commit
to EliahKagan/smmap
that referenced
this pull request
Jan 2, 2025
This is analogous to the gitdb test workflow and `setup.py` were updated in gitpython-developers/gitdb#114. 1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available. 2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap. 3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases. In particular, this change, due to (1), fixes the current CI failure for smmap observed in f31bfa3.
EliahKagan
added a commit
to EliahKagan/smmap
that referenced
this pull request
Jan 2, 2025
This is analogous to the gitdb test workflow and `setup.py` updates in gitpython-developers/gitdb#114. 1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available. 2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap. 3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases. In particular, this change, due to (1), fixes the current CI failure for smmap observed in f31bfa3.
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Jan 2, 2025
This is analogous to the 3.7-related CI change in gitdb that was part of gitpython-developers/gitdb#114, as to part of gitpython-developers/smmap#58. Since some tests are not yet passing on 3.13, this does not add 3.13 to CI, nor to the documentation of supported versions in `setup.py`. Note that the list there is not enforced; GitPython can already be installed on Python 3.13 and probably *mostly* works. (See gitpython-developers#1955 for details on other changes that should be made to fully support running GitPython on Python 3.13.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 is out, so it'd be nice if the next release of gitdb to PyPI included it in its metadata.
Though you might wanna wait for gitpython-developers/GitPython#1955?
https://pyreadiness.org/3.13/