Minor cleanup stuff, and better error handling #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As opposed to being Ok and then choking on parsing the returned JSON.
drozdziak1
pushed a commit
to drozdziak1/rust-ipfs-api
that referenced
this pull request
Jan 4, 2019
Added /pin/add endpoint call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly for you to look at commit f3d90dd and say whether or not it seems reasonable... Basically, currently, if the IPFS server returns an HTTP error then as far as the client is concerned it "worked" and returns
Ok. This commit adds a check for that.The other stuff is just bits and pieces of cleanup, and doesn't merge cleanly with your existing repo; I'll bring it up to date with your stuff and make a new PR.