anchor: add test suite for api integ tests #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurushao
force-pushed
the
api_integ_tests
branch
from
7257897
to
698d4dc
Compare
yurushao
commented
Jun 10, 2024
| @@ -133,11 +133,11 @@ export class BaseClient { | |||
| } | |||
|
|
|||
| getManager(): PublicKey { | |||
| return this.provider?.publicKey || new PublicKey(0); | |||
There was a problem hiding this comment.
if we cannot find manager public key just let it fail, because this should be a fatal error. Otherwise the error is swallowed and PublicKey(0) will lead to glam program errors.
0x0ece
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests succeeded in mainnet with api.glam.systems