added settings page, account selection menu styling, #243
+1,258
−557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0ece
approved these changes
Oct 12, 2024
fabiofederici
force-pushed
the
fabio-gui-oct2
branch
from
3d4f210
to
5117d24
Compare
…detail page, added openfunds csv/json links (disabled) as preview
…a stored in local storage
fabiofederici
force-pushed
the
fabio-gui-oct2
branch
from
e308f5b
to
1bb7ff1
Compare
yurushao
reviewed
Oct 14, 2024
| const API_CONFIG = { | ||
| url: 'https://rpc.helius.xyz/', // Correct Helius RPC endpoint | ||
| apiKey: process.env.NEXT_PUBLIC_HELIUS_API_KEY || '', // Use environment variable | ||
| }; |
There was a problem hiding this comment.
Don't need the separate the url and the api key
We currently use 1 env variable for the RPC endpoint NEXT_PUBLIC_SOLANA_RPC.
There was a problem hiding this comment.
moved it directly to the fetch, not sure what you mean with the second point. this must be a helius key
yurushao
reviewed
Oct 14, 2024
| jsonrpc: '2.0', | ||
| id: '1', | ||
| method: 'getTokenAccounts', | ||
| params: { |
There was a problem hiding this comment.
this should work if we don't have too many holders of a share class.
When a mint has lots of holders, the result from the rpc call is paginated, see limit and page params:
https://docs.helius.dev/compression-and-das-api/digital-asset-standard-das-api/get-token-accounts
There was a problem hiding this comment.
yes it goes all the way to 1000, figured that gives us enough time to find a proper solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.