-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New FundAccount + FundModel #94
Conversation
@@ -87,18 +87,18 @@ pub struct ShareClassOpenfundsModel { | |||
// Core | |||
// pub applied_subscription_fee_in_favour_of_distributor: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why lots of fields are being commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not implemented / too many fields = too costly to deser :(
let is_raw_openfunds = model.is_raw_openfunds.unwrap_or(false); | ||
let model = model.clone(); | ||
if !is_raw_openfunds { | ||
//TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document the TODO if it's still needed?
No description provided.