Pablo/dev 177 add pipeline check method to sdk #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloPardoGarcia
deleted the
pablo/dev-177-add-pipeline-check-method-to-sdk
branch
vkd
reviewed
Sep 5, 2024
Comment on lines
+30
to
+31
| PIPELINE_ID: ${{ secrets.PIPELINE_ID }} | ||
| PIPELINE_ACCESS_TOKEN: ${{ secrets.PIPELINE_ACCESS_TOKEN }} |
There was a problem hiding this comment.
It doesn't seem right.
At least, let's rename it into something more concrete, like INTEGRATION_TESTS_PIPELINE_ID.
There was a problem hiding this comment.
Base URL also needs to be configured - we shouldn't run integration tests on production environment.
At least, it could be staging.
There was a problem hiding this comment.
But anyway, conceptually we need to do integration tests differently.
There was a problem hiding this comment.
Good points! We can rename the secrets.
As for the environment, agree, we should test on a staging environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_access_token_validtoPipelineClientto return True if the access token is valid, False otherwise