Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure child node is a child of parent before removing #1438

Closed
wants to merge 1 commit into from
Closed

fix: ensure child node is a child of parent before removing #1438

wants to merge 1 commit into from

Commits on Aug 25, 2023

  1. fix: ensure child node is a child of parent before removing 

    Fixes glimmerjsGH-1401

If `current` isn't a child of `parent` calling `parent.removeChild(current)` will result in the error: `Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node`. This commonly occurs when the DOM is externally modified by a browser, such as when translating a page. The `nextSibling` may not be a child node of `parent`.
    @shama
    shama committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ff3396d View commit details
    Browse the repository at this point in the history