Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:#667 - Fixed load more button visible #668

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

sana7044
Copy link
Collaborator

@sana7044 sana7044 commented Dec 5, 2024

🛠 Description

This PR resolves the issue where the "Load More" button was visible even after loading the last prompt or entry in the Search Page, Manage Prompt and Entry Table.

Fix Details
Added a condition to check if the last prompt or entry has been loaded.
Ensured the "Load More" button is hidden once all data is loaded.
Updated relevant components for consistent behavior across the Search Page, Manage Prompt Table, and Manage Entry Table.

Fixes #667

✨ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧠 Rationale behind the change

--

🧪 All Test Suites Passed?

  • Manual tested
  • Vitest
  • Cypress
  • Verified the "Load More" button does not appear when the last prompt/entry is loaded.
  • Ensured clicking the button (if visible) does not cause unexpected behavior.
  • Tested on all affected pages to confirm consistent functionality.

📸 Screenshots (optional)

🏎 Quick checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sana7044 sana7044 added Type: Bug Something isn't working Type: External Suggestion coming from users labels Dec 5, 2024
@sana7044 sana7044 added this to the Release 3.0 milestone Dec 5, 2024
@sana7044 sana7044 self-assigned this Dec 5, 2024
@sana7044 sana7044 requested a review from marclupanc December 5, 2024 09:51
@marclupanc marclupanc merged commit a0347cb into develop Dec 12, 2024
5 checks passed
@marclupanc marclupanc deleted the 667-bug-load-more-button-visible branch December 12, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: External Suggestion coming from users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Load More Button Still Visible After Loading Last Prompt
2 participants