Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:#669 - fixed empty spaces name field #670

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

sana7044
Copy link
Collaborator

@sana7044 sana7044 commented Dec 7, 2024

🛠 Description

The system should not allow only spaces in the Name field.

Fixes #669

✨ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 All Test Suites Passed?

  • Manual tested
  • Vitest
  • Cypress

🏎 Quick checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sana7044 sana7044 added Type: Bug Something isn't working Type: External Suggestion coming from users labels Dec 7, 2024
@sana7044 sana7044 added this to the Release 3.0 milestone Dec 7, 2024
@sana7044 sana7044 self-assigned this Dec 7, 2024
@sana7044 sana7044 requested a review from marclupanc December 7, 2024 14:17
@marclupanc marclupanc merged commit 75cba02 into develop Dec 12, 2024
5 checks passed
@marclupanc marclupanc deleted the 669-bug-empty-spaces-name-field branch December 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: External Suggestion coming from users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] User Signup Allows Empty Spaces in the Name Field
2 participants