Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:#684 - Delete account #685

Merged
merged 10 commits into from
Jan 7, 2025
Merged

feat:#684 - Delete account #685

merged 10 commits into from
Jan 7, 2025

Conversation

sana7044
Copy link
Collaborator

@sana7044 sana7044 commented Jan 1, 2025

🛠 Description

This PR implements the ability for users to delete their own accounts directly from the Settings page.

Changes

  • Added a "Delete Account" button to the Settings page UI.
  • Clicking the button opens a confirmation dialog to prevent accidental deletions.
  • Integrated a confirmation dialog requiring users to type "DELETE" to confirm account deletion, reducing accidental actions.
  • Implemented account deletion from Firebase Authentication and associated Firestore data.
  • Ensures the user is automatically logged out post-deletion.
  • Added a success notification upon successful account deletion.

Fixes #684

✨ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧠 Rationale behind the change

--

🧪 All Test Suites Passed?

  • Manual tested
  • Cypress

📸 Screenshots (optional)

Screenshot from 2025-01-02 11-32-02

🏎 Quick checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sana7044 sana7044 added Type: Enhancement Enhancement to existing feature Type: External Suggestion coming from users labels Jan 1, 2025
@sana7044 sana7044 requested a review from marclupanc January 1, 2025 17:22
@sana7044 sana7044 self-assigned this Jan 1, 2025
@sana7044 sana7044 added this to the Release 3.0 milestone Jan 1, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 1, 2025

Deploying celebrityfanalyzer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40feb8b
Status: ✅  Deploy successful!
Preview URL: https://f509601b.celebrity-fanalyzer.pages.dev
Branch Preview URL: https://684-feat-delete-account.celebrity-fanalyzer.pages.dev

View logs

@marclupanc marclupanc merged commit 2edd0c5 into develop Jan 7, 2025
5 checks passed
@marclupanc marclupanc deleted the 684-feat-delete-account branch January 7, 2025 18:19
@marclupanc marclupanc added the Status: Completed Work done, review done label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Work done, review done Type: Enhancement Enhancement to existing feature Type: External Suggestion coming from users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] User Can Delete Their Own Account in Settings Page
2 participants