Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ErrorBoundary_test.js #451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ErrorBoundary_test.js #451

wants to merge 1 commit into from

Conversation

cardosource
Copy link

I changed the check from expect(component.getElement()).toBe(null); to expect(component.isEmptyRender()).toBe(true);.

Related Issue

Proposed Changes

  • Updated the test to better reflect the expected behavior of the ErrorBoundary.
  • Ensured the test verifies that nothing is rendered when there are no errors.
  • Improved clarity of the test's intention regarding rendering absence.

@cardosource
Update ErrorBoundary_test.js
829274f 
I changed the check from expect(component.getElement()).toBe(null); to expect(component.isEmptyRender()).toBe(true);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cardosource