Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASE calculator for TorchANI #34

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Fix ASE calculator for TorchANI #34

merged 2 commits into from
Jul 19, 2024

Conversation

WardLT
Copy link
Member

@WardLT WardLT commented Jul 19, 2024

It had a bug leading to #33. See aiqm/torchani#644

As torchANI has a code freeze, I just copied their calculator over to here for the time being.

Fixes #33

@coveralls
Copy link

coveralls commented Jul 19, 2024

Pull Request Test Coverage Report for Build 10012435687

Details

  • 57 of 60 (95.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 94.673%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cascade/learning/torchani/ase.py 53 56 94.64%
Totals Coverage Status
Change from base Build 9998012055: -0.01%
Covered Lines: 622
Relevant Lines: 657

💛 - Coveralls

@WardLT WardLT merged commit 7acb4fc into main Jul 19, 2024
2 of 4 checks passed
@WardLT WardLT deleted the new-calculator branch July 26, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with stresses for the Proxima calculator
2 participants