-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]: 지원서 생성 시 이벤트에 CaptainId 넘겨주도록 수정 #127
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,17 +10,17 @@ public class ApplyEventMapper { | |
|
||
public static ApplyAdapterEvent mapToApplyAdapterEventFrom(ApplyCreateEvent applyCreateEvent) { | ||
return new ApplyAdapterEvent( | ||
applyCreateEvent.getUserId(), | ||
applyCreateEvent.getCaptainId(), | ||
applyCreateEvent.getGroupId(), | ||
applyCreateEvent.getUserId(), | ||
applyCreateEvent.getApplyUserId(), | ||
ApplyEventType.APPLY_CREATE | ||
); | ||
} | ||
|
||
public static ApplyAdapterEvent mapToApplyAdapterEventFrom(ApplyStatusUpdateEvent applyStatusUpdateEvent) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ApplyCreateEvent, ApplyStautsUpdateEvent를 하나의 Event로 사용해도 될거 같은데 어떻게 생각하시나요? @jihwan2da There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
return new ApplyAdapterEvent( | ||
applyStatusUpdateEvent.getUserId(), | ||
applyStatusUpdateEvent.getApplyGroupId(), | ||
applyStatusUpdateEvent.getCaptainId(), | ||
applyStatusUpdateEvent.getGroupId(), | ||
applyStatusUpdateEvent.getApplyUserId(), | ||
getApplyEventType(applyStatusUpdateEvent.getStatus()) | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존의 userId는 지원서를 작성한 userId인지, 지원서 그룹의 captainId인지 헷갈릴 수 있어 변수명을 captainId로 변경했습니다.