[FEAT]: user Id로 마이페이지 조회 API 구현 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoosky
commented
Aug 31, 2023
|
|
||
| public Status getStatusByGroupAndUser(Long groupId, Long userId) { | ||
| Apply apply = applyQueryHandler.findOptionalByUserIdAndGroupId(userId, groupId) | ||
| .orElseGet(() -> Apply.builder().status(Status.NONE).build()); |
There was a problem hiding this comment.
group에 대한 로그인 user의 지원서가 없다면 Status 값이 NONE인 Apply 객체를 생성했습니다.
Optional.isPresent() 메서드를 통해 분기처리해도 되지만, (apply가 존재하는 경우 Optional.get().getStatus() 반환, 없는 경우 Status.NONE 반환) 위 코드가 가독성 면에서 더 좋다고 생각해 Status 값이 NONE인 Apply 객체를 생성했습니다.
| @@ -9,6 +9,7 @@ public enum Status { | |||
| APPROVE("승인"), | |||
| REFUSE("거절"), | |||
| WAIT("대기"), | |||
| NONE("없음"), | |||
There was a problem hiding this comment.
지원서가 없는 상태를 나타내기 위해 NONE 상수를 추가했습니다.
| this.content = content; | ||
| this.reason = reason; | ||
| this.status = Status.WAIT; | ||
| this.isCheckRejected = false; |
There was a problem hiding this comment.
@builder 어노테이션을 Entity 자체에 정의한 뒤, @Builder.Default 어노테이션을 통해 status, isCheckRejected default값을 지정했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number
작업 사항