improve perf searching ids in dropdowns

glpi-project · Aug 23, 2024 · 137fa6f · 137fa6f
1 parent f6b526b
commit 137fa6f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ The present file will list all changes made to the project; according to the
 ### Added
 
 ### Changed
+- Searching IDs in dropdowns now matches the beginning of the ID instead of anywhere in the ID.
 
 ### Deprecated
 

diff --git a/src/Dropdown.php b/src/Dropdown.php
@@ -3169,10 +3169,9 @@ public static function getDropdownValue($post, $json = true)
                 ];
 
                 if (
-                    $_SESSION['glpiis_ids_visible']
-                    && is_numeric($post['searchText']) && (int)$post['searchText'] == $post['searchText']
+                    $_SESSION['glpiis_ids_visible'] && (int) $post['searchText'] === $post['searchText']
                 ) {
-                    $orwhere[$table . '.' . $item->getIndexName()] = ['LIKE', "%{$post['searchText']}%"];
+                    $orwhere[$table . '.' . $item::getIndexName()] = ['LIKE', "{$post['searchText']}%"];
                 }
 
                 if ($item instanceof CommonDCModelDropdown) {