fix(Email): unsanitize email before check validation

glpi-project · Sep 29, 2023 · 2a36c33 · 2a36c33
1 parent cbdc8ef
commit 2a36c33
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/UserEmail.php b/src/UserEmail.php
@@ -33,6 +33,8 @@
  * ---------------------------------------------------------------------
  */
 
+use Glpi\Toolbox\Sanitizer;
+
 /**
  * UserEmail class
  **/
@@ -274,7 +276,7 @@ public function prepareInputForUpdate($input)
      */
     private function checkInputEmailValidity(array $input): bool
     {
-        return isset($input['email']) && !empty($input['email']) && GLPIMailer::validateAddress($input['email']);
+        return isset($input['email']) && !empty($input['email']) && GLPIMailer::validateAddress(Sanitizer::unsanitize($input['email']));
     }
 
 

diff --git a/tests/units/GLPIMailer.php b/tests/units/GLPIMailer.php
@@ -67,6 +67,7 @@ protected function valideAddressProvider()
             ["test@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.dot", true],
             ["test@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.dot", false],
             ["test@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", true],
+            ["abcd'efgh@example.com", true],
         ];
     }