fix(APIRest): remove not functional massive action

glpi-project · Aug 28, 2024 · 53a22e7 · 53a22e7
1 parent 5bb691a
commit 53a22e7
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 15 deletions.
diff --git a/apirest.md b/apirest.md
@@ -1300,10 +1300,6 @@ $ curl -X GET \
     "key": "MassiveAction:delete",
     "label": "Put in trashbin"
   },
-  {
-    "key": "MassiveAction:add_transfer_list",
-    "label": "Add to transfer list"
-  },
   {
     "key": "Appliance:add_item",
     "label": "Associate to an appliance"
@@ -1422,10 +1418,6 @@ $ curl -X GET \
     "key": "MassiveAction:delete",
     "label": "Put in trashbin"
   },
-  {
-    "key": "MassiveAction:add_transfer_list",
-    "label": "Add to transfer list"
-  },
   {
     "key": "Appliance:add_item",
     "label": "Associate to an appliance"

diff --git a/src/MassiveAction.php b/src/MassiveAction.php
@@ -700,6 +700,7 @@ public static function getAddTransferList(array &$actions)
         if (
             Session::haveRight('transfer', READ)
             && Session::isMultiEntitiesMode()
+            && !isAPI()
         ) {
             $actions[__CLASS__ . self::CLASS_ACTION_SEPARATOR . 'add_transfer_list']
                   = "<i class='fa-fw fas fa-level-up-alt'></i>" .

diff --git a/tests/web/APIRest.php b/tests/web/APIRest.php
@@ -815,7 +815,6 @@ protected function testGetMassiveActionsProvider(): array
                     ["key" => "Infocom:activate",                "label" => "Enable the financial and administrative information"],
                     ["key" => "MassiveAction:delete",            "label" => "Put in trashbin"],
                     ["key" => "ObjectLock:unlock",               "label" => "Unlock items"],
-                    ["key" => "MassiveAction:add_transfer_list", "label" => "Add to transfer list"],
                     ["key" => "Appliance:add_item",              "label" => "Associate to an appliance"],
                     ["key" => "Item_Rack:delete",                "label" => "Remove from a rack"],
                     ["key" => "Item_OperatingSystem:update",     "label" => "Operating systems"],
@@ -853,7 +852,6 @@ protected function testGetMassiveActionsProvider(): array
                     ["key" => "Infocom:activate",                "label" => "Enable the financial and administrative information"],
                     ["key" => "MassiveAction:delete",            "label" => "Put in trashbin"],
                     ["key" => "ObjectLock:unlock",               "label" => "Unlock items"],
-                    ["key" => "MassiveAction:add_transfer_list", "label" => "Add to transfer list"],
                     ["key" => "Appliance:add_item",              "label" => "Associate to an appliance"],
                     ["key" => "Item_Rack:delete",                "label" => "Remove from a rack"],
                     ["key" => "Item_OperatingSystem:update",     "label" => "Operating systems"],
@@ -950,11 +948,6 @@ protected function testGetMassiveActionParametersProvider(): array
                 'status' => 200,
                 'response' => [],
             ],
-            [
-                'url' => 'getMassiveActionParameters/Computer/MassiveAction:add_transfer_list',
-                'status' => 200,
-                'response' => [],
-            ],
             [
                 'url' => 'getMassiveActionParameters/Computer/Appliance:add_item',
                 'status' => 200,