Prevent exception when checked schema is empty #15791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
orthagh
approved these changes
Oct 16, 2023
trasher
reviewed
Oct 16, 2023
There was a problem hiding this comment.
This should not happen. Anyway, if this really happen; and if we want to handle that kind of edge case, we have to log something or tell user the schema is incorrect.
If SQL schema file is corrupted, which other files are as well? An kind of corruption detection would be a better solution that just hidding the error/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be edge cases where GLPI fails to extract tables from a
glpi-XXX-empty.sqlschema file. For instance, if the file is corrupted.In this case, to avoid having an exception (see #15767), the code have to be adapted.