Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ticket): restores group's tooltip #17589

Merged
merged 5 commits into from
Aug 21, 2024
Merged

fix(ticket): restores group's tooltip #17589

merged 5 commits into from
Aug 21, 2024

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Jul 24, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets !33820

In 9.5, on tickets, groups had a tooltip allowing the complete name and comment to be displayed, but this was no longer present on 10.0.

Before:
image

After:
image

AdrienClairembault
AdrienClairembault requested changes Jul 25, 2024
View reviewed changes
ajax/comments.php Outdated Show resolved Hide resolved
ajax/comments.php Outdated Show resolved Hide resolved
templates/components/group/info_card.html.twig Outdated Show resolved Hide resolved
templates/components/group/info_card.html.twig Outdated Show resolved Hide resolved
AdrienClairembault
AdrienClairembault requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the changes in the latest commit but I think you missed my question on the "multiples values" part.

@Rom1-B Rom1-B requested a review from trasher August 6, 2024 08:30
trasher
trasher approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cedric-anne cedric-anne added this to the 10.0.17 milestone Aug 21, 2024
@cedric-anne cedric-anne merged commit 91b56e2 into glpi-project:10.0/bugfixes Aug 21, 2024
6 checks passed
@Rom1-B Rom1-B deleted the support_33820 branch August 21, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@trasher trasher trasher approved these changes

@orthagh orthagh Awaiting requested review from orthagh

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
10.0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@Rom1-B @trasher @cedric-anne @AdrienClairembault