Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper "Form\SubmitAnswerController" #17649

Conversation

AdrienClairembault
Copy link
Contributor

Replace legacy ajax file by a proper controller.

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

@AdrienClairembault AdrienClairembault self-assigned this Aug 6, 2024
@AdrienClairembault AdrienClairembault force-pushed the chore/forms/submit-anwsers-controller branch 2 times, most recently from e3a6ddd to 6ee723b Compare August 6, 2024 10:20
@AdrienClairembault AdrienClairembault marked this pull request as ready for review August 6, 2024 10:21
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Translated messages ar enot the smae, but they've been introduced in main, I guess this is not a big issue.

Please note I'm not very familiar yet with GLPI controllers

@AdrienClairembault AdrienClairembault marked this pull request as draft August 21, 2024 09:46
@AdrienClairembault AdrienClairembault force-pushed the chore/forms/submit-anwsers-controller branch from 6ee723b to 4d4cc8f Compare August 22, 2024 13:30
@AdrienClairembault AdrienClairembault marked this pull request as ready for review August 22, 2024 13:49
@AdrienClairembault
Copy link
Contributor Author

Rebased to latest main.

@orthagh orthagh added the Forms label Aug 23, 2024
@AdrienClairembault AdrienClairembault force-pushed the chore/forms/submit-anwsers-controller branch from 4d4cc8f to 533656d Compare September 4, 2024 12:44
@AdrienClairembault
Copy link
Contributor Author

AdrienClairembault commented Sep 4, 2024

Rebased to latest main (PHPStan level 4 was checked).

@cedric-anne cedric-anne merged commit 5405662 into glpi-project:main Sep 9, 2024
7 checks passed
@AdrienClairembault AdrienClairembault deleted the chore/forms/submit-anwsers-controller branch September 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants