Fix escaping handling in formatUserName() and getUserName()
#17872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
11.0/escape-username
branch
from
74f0bf8 to
de33d4e
Compare
4 tasks
|
@AdrienClairembault Could you help me to indentify what could cause something like an infinite loop in |
cedric-anne
force-pushed
the
11.0/escape-username
branch
2 times, most recently
from
96b8e29 to
78c02c9
Compare
cedric-anne
force-pushed
the
11.0/escape-username
branch
from
78c02c9 to
5c839ef
Compare
AdrienClairembault
approved these changes
Sep 18, 2024
trasher
approved these changes
Sep 18, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Still a draft, tests may fail.
getUserName()andformatUserName()methods to have one that retunrs a raw username (getUserName()/formatUserName()) and one that returns a HTML link (getUserLink()/formatUserLink()).getUserName()had a$link=2parameter value that completely changed its behaviour to return the user inforcard + the user link + the link URL. I moved this info card generation into aUser::getInfoCard()method.