-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(SavedSearch): Force user to validate criteria before saved search #18385
Merged
cedric-anne
merged 1 commit into
glpi-project:10.0/bugfixes
from
stonebuzz:fix_saved_search
Jan 16, 2025
Merged
Fix(SavedSearch): Force user to validate criteria before saved search #18385
cedric-anne
merged 1 commit into
glpi-project:10.0/bugfixes
from
stonebuzz:fix_saved_search
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awaiting user feedback |
cedric-anne
reviewed
Dec 5, 2024
2 tasks
cconard96
suggested changes
Dec 27, 2024
orthagh
requested changes
Jan 14, 2025
orthagh
approved these changes
Jan 15, 2025
cconard96
approved these changes
Jan 15, 2025
cedric-anne
reviewed
Jan 15, 2025
cedric-anne
force-pushed
the
fix_saved_search
branch
from
January 16, 2025 07:51
3b615e2
to
b35ac02
Compare
cedric-anne
approved these changes
Jan 16, 2025
AdrienClairembault
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Perhaps an alternative to #18376.
After further review, I believe the issue here is that the saved search system expects the user to execute a search based on their criteria at least once (to include them in the URL).
See
GenericView.js L102
If the user does not execute a search at least once, the default search for the item type is used and saved in the database.
Since I don’t see how to extract the search
convert it into a URL as shown here
and then pass it to the modal (from
GenericView.js L102
)I simply propose checking whether
window.location.search
is not empty or does not correspond to a search reset (reset=reset
).Screenshots (if appropriate):