Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump tinymce from 7.3.0 to 7.6.0 #18572

Merged
merged 2 commits into from
Dec 18, 2024
Merged

build(deps): bump tinymce from 7.3.0 to 7.6.0 #18572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85bdaa3
build(deps): bump tinymce from 7.3.0 to 7.6.0
dependabot[bot] Dec 18, 2024
832de75
Update our tests to match new tinymce behavior
AdrienClairembault Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"spin.js": "^4.1.2",
"swagger-ui-dist": "^5.18.2",
"tinycolor2": "^1.6.0",
"tinymce": "^7.3.0",
"tinymce": "^7.6.0",
"tinymce-i18n": "^24.11.25",
"vue": "^3.5.13"
},
Expand Down
11 changes: 6 additions & 5 deletions tests/cypress/e2e/form/form_destination.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,9 @@ describe('Form destination', () => {
.should('be.checked')
;
cy.get("@content_field").parents().find("#tinymce")
.should('have.attr', 'contenteditable', "false")
.type('This field is not writable')
;
cy.get("@content_field").should('have.text', ''); // Nothing was written.

// Ensure auto config values have been loaded for the "content" field
cy.get("@content_field")
Expand All @@ -99,9 +100,8 @@ describe('Form destination', () => {
// Disable auto config for the "content" field (tinymce)
cy.get("@content_auto_config_checkbox").uncheck();
cy.get("@content_field").parents().find("#tinymce")
.should('have.attr', 'contenteditable', "true")
.type('This field is writable')
;
cy.get("@content_field").type('Manual content');

// Save changes (page reload)
cy.findByRole('button', {'name': "Update item"}).click();
Expand All @@ -113,15 +113,16 @@ describe('Form destination', () => {

// Ensure the manual values are still there
cy.get("@content_auto_config_checkbox").should('not.be.checked');
cy.get("@content_field").should('have.text', 'Manual content');
cy.get("@content_field").should('have.text', 'This field is writable');
});

describe('Revert to auto configurated values', () => {
// Re-enable auto config for the "content" field
cy.get("@content_auto_config_checkbox").check();
cy.get("@content_field").parents().find("#tinymce")
.should('have.attr', 'contenteditable', "false")
.type('This field is not writable')
;
cy.get("@content_field").should('have.text', 'This field is writable'); // Previous content, no chane=ges

// Save changes (page reload)
cy.findByRole('button', {'name': "Update item"}).click();
Expand Down
Loading