Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset user default group when link between user and group is deleted #18573

Merged

Conversation

RomainLvr
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35654
  • Here is a brief description of what this PR does

When you delete the link between a user and a group, if this group is the user's default group, it remains so even after the link has been deleted.

Screenshots (if appropriate):

396580549-7cc06cfc-e3eb-4d07-a33e-f93b6b268864

src/Group_User.php Outdated Show resolved Hide resolved
@RomainLvr RomainLvr requested review from stonebuzz and Rom1-B and removed request for Rom1-B December 19, 2024 08:56
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a commit to move the $planning_k definition line at the same place it is used.

@cedric-anne cedric-anne added this to the 10.0.18 milestone Dec 19, 2024
@trasher trasher merged commit d9ed480 into glpi-project:10.0/bugfixes Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants