Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove external dependencies for HTTP requests #24

Open
ajsb85 opened this issue Oct 26, 2017 · 4 comments
Open

Remove external dependencies for HTTP requests #24

ajsb85 opened this issue Oct 26, 2017 · 4 comments
Assignees
@DIOHz0r @btry
Labels
hacktoberfest performance refactor

Comments

@ajsb85
Copy link
Contributor

ajsb85 commented Oct 26, 2017

Hi, @DIOHz0r

For the next milestone (v2) of the library, please remove external dependencies of the HTTP requests (Guzzle)

Thanks
@ajsb85 ajsb85 added this to the 2.0 milestone Oct 26, 2017
@btry
Copy link
Collaborator

btry commented Oct 27, 2017 •
edited by ajsb85
Loading

Hi, @ajsb85

Why?

@ajsb85
Copy link
Contributor Author

ajsb85 commented Nov 1, 2017

Hi, @btry

Read this reference: https://blog.jooq.org/2016/08/11/all-libraries-should-follow-a-zero-dependency-policy/

@btry
Copy link
Collaborator

btry commented Nov 1, 2017

well... Waiting for the nodeJS world show me the way :D

@ajsb85 ajsb85 self-assigned this Feb 2, 2018
@ajsb85 ajsb85 assigned DIOHz0r and btry and unassigned ajsb85 Apr 25, 2018
@btry
Copy link
Collaborator

btry commented Apr 25, 2018

Hi

Without guzzle we loose the ability to improve the library to use asynchronous requests. To be considered.

Also, it follows PSR-7 then it contributes to follow the best practices of PHP development, t hen better code and more maintainable projects.

@ajsb85 ajsb85 removed this from the 2.0 milestone May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DIOHz0r DIOHz0r

@btry btry

Labels
hacktoberfest performance refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajsb85 @DIOHz0r @btry