Keep subset menu open when deleting a subset #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* to allow for deleting multiple subsets * toggleSubset(index) seems to be necessary in order for internal bookkeeping to remove the entry from the menu (which used to be called via event propagation, but is not prevented with the click.stop)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 89 89
Lines 4992 4992
=======================================
Hits 4337 4337
Misses 655 655 ☔ View full report in Codecov by Sentry. |
astrofrog
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents the subset menu from closing when clicking on the "delete" icon for a subset, to enable deleting multiple subsets without having to repeatedly re-open the menu manually. This retains the behavior that the menu should close when selecting a subset when multiple selections are disabled.
Calling
toggleSubset(index)seems to be necessary in order for internal bookkeeping to remove the entry from the menu (which used to be called via event propagation, but would otherwise be prevented with the@click.stop).