Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set large data limits since the warning appears too late anyway #406

Merged
merged 1 commit into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion glue_jupyter/bqplot/histogram/viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class BqplotHistogramView(BqplotBaseView):

allow_duplicate_data = False
allow_duplicate_subset = False
large_data_size = 1e5
is2d = False

_state_cls = HistogramViewerState
Expand Down
1 change: 0 additions & 1 deletion glue_jupyter/bqplot/image/viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class BqplotImageView(BqplotBaseView):

allow_duplicate_data = False
allow_duplicate_subset = False
large_data_size = 2e7

_layer_style_widget_cls = {BqplotImageLayerArtist: ImageLayerStateWidget,
BqplotImageSubsetLayerArtist: ImageSubsetLayerStateWidget,
Expand Down
1 change: 0 additions & 1 deletion glue_jupyter/bqplot/scatter/viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class BqplotScatterView(BqplotBaseView):

allow_duplicate_data = False
allow_duplicate_subset = False
large_data_size = 1e7

_state_cls = ScatterViewerState
_options_cls = ScatterViewerStateWidget
Expand Down
1 change: 0 additions & 1 deletion glue_jupyter/ipyvolume/scatter/viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ class IpyvolumeScatterView(IpyvolumeBaseView):

allow_duplicate_data = False
allow_duplicate_subset = False
large_data_size = 1e7

_state_cls = Scatter3DViewerState
_options_cls = Viewer3DStateWidget
Expand Down
2 changes: 0 additions & 2 deletions glue_jupyter/ipyvolume/volume/viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

class IpyvolumeVolumeView(IpyvolumeBaseView):

large_data_size = 1e8

_state_cls = VolumeViewerState
_options_cls = Viewer3DStateWidget
_data_artist_cls = IpyvolumeVolumeLayerArtist
Expand Down
1 change: 0 additions & 1 deletion glue_jupyter/table/viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ def __init__(self, viewer_state):
class TableViewer(IPyWidgetView):
allow_duplicate_data = False
allow_duplicate_subset = False
large_data_size = 1e100 # Basically infinite (a googol)

_state_cls = TableState
_options_cls = TableViewerStateWidget
Expand Down