Set InteractCheckableTool._roi to None on deactivate

[dhomeier]

Description

Reset any _roi in an InteractCheckableTool when calling deactivate.
This is to avoid inheriting changed attributes like rotation angle from previously created selections. It will not reset the attributes when creating new ROIs with the same (left open) tool instance.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (307a11d) 86.63% compared to head (b26dd56) 86.64%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   86.63%   86.64%           
=======================================
  Files          89       89           
  Lines        5163     5165    +2     
=======================================
+ Hits         4473     4475    +2     
  Misses        690      690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pllim]

Is this trying to solve the same problem that I approached differently in #416 ? Or is this for something else?

[rosteen]

Is this trying to solve the same problem that I approached differently in #416 ? Or is this for something else?

This is trying to solve the problem I was hacking around in spacetelescope/jdaviz#2639.

[rosteen]

@dhomeier This looks good to go in to me, I confirmed on the Jdaviz side that it fixes the unwanted behavior.

[pllim]

tl;dr -- This does not reintroduce the problem where the angle resets when you click and drag a rotated shape, does it?

[rosteen]

tl;dr -- This does not reintroduce the problem where the angle resets when you click and drag a rotated shape, does it?

The existing problem of the gray preview not matching the rotation of the actual subset persists, but it's not worse than the current state. The dragged subset retains its angle in my testing.

[astrofrog]

Looks good, thanks!