Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3D VisPy viewers #453

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

astrofrog
Copy link
Member

This exposes the vispy viewers as optional widgets for scatter3d and volshow, as alternatives to ipyvolume.

This requires:

@astrofrog astrofrog marked this pull request as ready for review June 26, 2024 12:41
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (015b428) to head (488287d).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
glue_jupyter/app.py 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   86.15%   86.04%   -0.12%     
==========================================
  Files          90       90              
  Lines        5209     5223      +14     
==========================================
+ Hits         4488     4494       +6     
- Misses        721      729       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog merged commit b7ab11f into glue-viz:main Jun 26, 2024
23 of 25 checks passed
@astrofrog astrofrog added the enhancement New feature or request label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant