Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using non-SVG icons in toolbar #465

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Carifio24
Copy link
Member

Currently the way the Jupyter toolbar is set up, we can only use SVG icons. This is usually fine, as most of our glue-core icons are available as both png or svg. However, there are some icons (the rotation icon in the vispy viewers, for example) for which we only have pngs.

This PR updates the format that gets passed to icon_path to depend on the path for the icon. If a valid image MIME type can't be determined, then it raises an error.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.06%. Comparing base (1d9c74e) to head (93005e7).
Report is 16 commits behind head on main.

Files Patch % Lines
glue_jupyter/common/toolbar_vuetify.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   86.04%   86.06%   +0.02%     
==========================================
  Files          90       90              
  Lines        5224     5240      +16     
==========================================
+ Hits         4495     4510      +15     
- Misses        729      730       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog merged commit f0a47fd into glue-viz:main Aug 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants