From c4f543cd7de8eae17ad10124976f9724c6fd0d21 Mon Sep 17 00:00:00 2001 From: Kyle Conroy Date: Thu, 22 Aug 2024 09:25:51 -0400 Subject: [PATCH 1/2] disable density map image broadcast --- glue_jupyter/bqplot/scatter/layer_artist.py | 1 + glue_jupyter/bqplot/scatter/scatter_density_mark.py | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/glue_jupyter/bqplot/scatter/layer_artist.py b/glue_jupyter/bqplot/scatter/layer_artist.py index 6434f052..a334676a 100644 --- a/glue_jupyter/bqplot/scatter/layer_artist.py +++ b/glue_jupyter/bqplot/scatter/layer_artist.py @@ -146,6 +146,7 @@ def __init__(self, view, viewer_state, layer_state=None, layer=None): vmin=self.density_auto_limits.min, vmax=self.density_auto_limits.max, histogram2d_func=self.compute_density_map, + visible=False ) self.view.figure.marks = list(self.view.figure.marks) + [ diff --git a/glue_jupyter/bqplot/scatter/scatter_density_mark.py b/glue_jupyter/bqplot/scatter/scatter_density_mark.py index cdccbf58..0126b172 100644 --- a/glue_jupyter/bqplot/scatter/scatter_density_mark.py +++ b/glue_jupyter/bqplot/scatter/scatter_density_mark.py @@ -69,6 +69,7 @@ def __init__( stretch=None, dpi=None, external_padding=None, + visible=True, ): # FIXME: need to use weakref to avoid circular references @@ -91,6 +92,7 @@ def __init__( self.vmin = vmin self.vmax = vmax self.stretch = stretch + self.visible = visible if dpi is not None: self.dpi = dpi @@ -194,7 +196,7 @@ def _update_counts(self, *args, **kwargs): def _update_rendered_image(self, *args, **kwargs): - if self._counts is None: + if self._counts is None or not self.visible: self.image = EMPTY_IMAGE return From 54499a8ce32ca5248d70e2976ab22c9906f4154a Mon Sep 17 00:00:00 2001 From: Derek Homeier Date: Tue, 27 Aug 2024 15:09:09 +0200 Subject: [PATCH 2/2] Add image update on visibility change --- glue_jupyter/bqplot/scatter/scatter_density_mark.py | 1 + 1 file changed, 1 insertion(+) diff --git a/glue_jupyter/bqplot/scatter/scatter_density_mark.py b/glue_jupyter/bqplot/scatter/scatter_density_mark.py index 0126b172..e110b757 100644 --- a/glue_jupyter/bqplot/scatter/scatter_density_mark.py +++ b/glue_jupyter/bqplot/scatter/scatter_density_mark.py @@ -108,6 +108,7 @@ def __init__( self.observe(self._update_rendered_image, "vmin") self.observe(self._update_rendered_image, "vmax") self.observe(self._update_rendered_image, "stretch") + self.observe(self._update_rendered_image, "visible") self._scale_image = ColorScale() self._scales = {