Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor viewer classes to split out Qt from non-Qt part, and define Jupyter viewers #381

Merged
merged 28 commits into from
May 23, 2024
Merged

Refactor viewer classes to split out Qt from non-Qt part, and define Jupyter viewers #381

merged 28 commits into from
May 23, 2024

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented May 17, 2024 •
edited
Loading

VisPy now works inside Jupyter notebook/lab thanks to jupyter_rfb, so this PR aims to split out the Qt-specific parts of this package and define separate Qt and Jupyter viewers. Main tasks to do:

  • Develop ipyvuetify option panels similar to what we use for the default viewers in glue-jupyter and set up a notebook to try these out without specific viewers. For now have this live in glue-vispy-viewers
  • Split out Qt code from scatter viewer and add new Jupyter viewer
  • Split out Qt code from volume viewer and add new Jupyter viewer
  • Get selection tools to work properly
  • Adjust glue-jupyter to make it possible to choose vispy as a front-end for the 3D viewers
  • Make it possible to run tests without Qt
  • Add visual tests, perhaps in glue-jupyter since the infrastructure is there already
  • Decide whether to move any code to glue-core/glue-jupyter/glue-qt

@astrofrog astrofrog mentioned this pull request May 22, 2024
Merged
@astrofrog
Started refactoring viewer classes to split out Qt from non-Qt part, …
7cdb072 
…and create Jupyter viewers
@astrofrog
More changes
a23e8c2
@astrofrog
More fixes, and started to add notebook to test out state widgets
b8ea265
@astrofrog
Added viewer and layer Jupyter widget for 3D scatter
b70d182
@astrofrog
Updated imports and isolated Qt-specific tests
c713077
@astrofrog
Add patch for import of Qt viewer from session files
9d2d6e8
@astrofrog
Fix code style
f028216
@astrofrog
Update package_data
334bed3
@astrofrog
Split out Qt code for volume viewer
2910ad1
@astrofrog
Fix tests and codestyle
da5a360
@astrofrog
Added Jupyter widgets for volume viewer
c61e454
@astrofrog
Fix codestyle
ced303c
@astrofrog
Added Jupyter volume viewer
9f4fbf9
@astrofrog
Fix toolbar in Jupyter
edab34b
@astrofrog
Fix Qt toolbar
10bfa64
@astrofrog
Skip qt/ directories when collecting tests if not using Qt
5fc87d9
@astrofrog
Make it possible to run the tests without Qt
c9dccfc
@astrofrog
Update CI configuration to run tests with and without Qt
1d94831
@astrofrog astrofrog changed the title Started refactoring viewer classes to split out Qt from non-Qt part, and define Jupyter viewers Refactor viewer classes to split out Qt from non-Qt part, and define Jupyter viewers May 23, 2024
@astrofrog astrofrog marked this pull request as ready for review May 23, 2024 12:09
@astrofrog astrofrog merged commit 7a66783 into glue-viz:main May 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@astrofrog