Allow view to keep rotating while other tools are used #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It took me a bit to hunt this down, but after noticing that only the EDIT: The issue was actually glue-viz/glue-qt#23, which I resolved by also using dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #334. I think the most straightforward way to do this is to have the rotation tool not be a
CheckableTool, but instead just be aToolwhich internally tracks whether it's currently rotating or not. We also got a request for this functionality recently.Since this a frontend-agnostic tool, there isn't way to do something like update the icon without creating frontend-specific subclasses, which feels like overkill to me when the tooltip pretty clearly states the button function.