From c3bf470d0240b9015102311c0c61bdb77972311b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Pereda?= <jose.pereda@gluonhq.com>
Date: Mon, 9 Sep 2024 09:43:08 +0200
Subject: [PATCH] checks for static lib (#1278)

---
 .../target/AbstractTargetConfiguration.java   | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/main/java/com/gluonhq/substrate/target/AbstractTargetConfiguration.java b/src/main/java/com/gluonhq/substrate/target/AbstractTargetConfiguration.java
index 7f160b43..da010879 100644
--- a/src/main/java/com/gluonhq/substrate/target/AbstractTargetConfiguration.java
+++ b/src/main/java/com/gluonhq/substrate/target/AbstractTargetConfiguration.java
@@ -81,7 +81,6 @@ public abstract class AbstractTargetConfiguration implements TargetConfiguration
 
     private static final List<String> baseNativeImageArguments = Arrays.asList(
             "-Djdk.internal.lambda.eagerlyInitialize=false",
-            "-Ddebug.jdk.graal.jvmciConfigCheck=warn",
             "--no-server",
             "-H:+SharedLibrary",
             "-H:+AddAllCharsets",
@@ -190,16 +189,17 @@ public boolean compile() throws IOException, InterruptedException {
 
     @Override
     public boolean link() throws IOException, InterruptedException {
+        if (projectConfiguration.isStaticLibrary()) {
+            Logger.logSevere("Error: Don't call link to create a static lib");
+            return false;
+        }
+
         compileAdditionalSources();
 
         String appName = projectConfiguration.getAppName();
         Path gvmPath = paths.getGvmPath();
         Path objectFile = getProjectObjectFile();
-        List<String> linkerLibraryPathFlags = getLinkerLibraryPathFlags();
 
-        if (projectConfiguration.isStaticLibrary()) {
-            return true;
-        }
         ProcessRunner linkRunner = new ProcessRunner(getLinker());
 
         Path gvmAppPath = gvmPath.resolve(appName);
@@ -219,7 +219,7 @@ public boolean link() throws IOException, InterruptedException {
                 projectConfiguration.isUsePrismSW()));
 
         linkRunner.addArgs(getTargetSpecificLinkOutputFlags());
-        linkRunner.addArgs(linkerLibraryPathFlags);
+        linkRunner.addArgs(getLinkerLibraryPathFlags());
         linkRunner.addArgs(getNativeLibsLinkFlags());
         linkRunner.addArgs(projectConfiguration.getLinkerArgs());
         linkRunner.setInfo(true);
@@ -322,10 +322,10 @@ public boolean createStaticLib() throws IOException, InterruptedException {
             Logger.logSevere("Error building a static library: error compiling the native image");
             return false;
         }
-        if (!link()) {
-            Logger.logSevere("Error building a static library: error linking the native image");
-            return false;
-        }
+
+        // make sure static Java/JavaFX libraries are available
+        getLinkerLibraryPaths();
+
         ProcessRunner createStaticLibRunner = new ProcessRunner(getStaticArchiver());
         createStaticLibRunner.addArg(getStaticArchiverArgs());
         Path dest = paths.getGvmPath().resolve("lib" + projectConfiguration.getAppName() + ".a");