Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message when called with non-existent feature #408

Open
fbalak opened this issue Aug 1, 2017 · 1 comment
Open

No error message when called with non-existent feature #408

fbalak opened this issue Aug 1, 2017 · 1 comment

Comments

@fbalak
Copy link

fbalak commented Aug 1, 2017

gdeploy called with configuration file that contains non-existent feature (in reproducer it is aaa) returns no error message and exit code 0. There should be some error message when called invalid file and exit code should be > 0.

Reproducer:

$ echo "[hosts]
> localhost
> 
> [aaa]
> " > test.conf
$
$ gdeploy -c test.conf
$ echo $?
0

Tested with gdeploy 2.0.1 on CentOS Linux 7

@sac
Copy link
Member

sac commented Oct 3, 2017

@fbalak this behavior is because we have some ad-hoc sections present from very early releases.
Documented at:
https://github.com/gluster/gdeploy/blob/master/gdeploylib/call_features.py#L52

This is a valid issue though. Once we rework and remove those sections, I will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants