CSUB-591: Updates for docker-compose.yml #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
remove_bogus_docker-compose
branch
from
866a79b
to
06cac00
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1145 +/- ##
=======================================
Coverage 74.62% 74.62%
=======================================
Files 74 74
Lines 10686 10686
=======================================
Hits 7974 7974
Misses 2712 2712 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
For full LLVM coverage report click here! |
jonZlotnik
requested changes
Jun 20, 2023
atodorov
force-pushed
the
remove_bogus_docker-compose
branch
from
06cac00
to
94de9da
Compare
atodorov
changed the title
jonZlotnik
previously approved these changes
Jun 20, 2023
it doesn't seem to be used anywhere and also looks like a build compose, not an example of how creditcoin-node should be run
Note: testnet chain spec already specifies boot node so no need to hard-code it here
atodorov
force-pushed
the
remove_bogus_docker-compose
branch
from
94de9da
to
76fc399
Compare
this only make sense if we specify --base-path, which we do in the next section
AdaJane
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: