CSUB-589: changed sensitive input to interactive or env vars #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1151 +/- ##
=======================================
Coverage 74.62% 74.62%
=======================================
Files 74 74
Lines 10686 10686
=======================================
Hits 7974 7974
Misses 2712 2712 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
For full LLVM coverage report click here! |
atodorov
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Using a stash seed from ENV looks good:
$ node dist/index.js bond -u ws://127.0.0.1:9946 -c 5EEoJZYPpTYGX1t3shaQbqhRmqvdvoaTycY1gJ4TB8spDgPp -a 1000005 -r Staked
2023-06-21 15:12:27 API/INIT: RPC methods not decorated: creditcoin_hashrate, task_getOffchainNonceKey
2023-06-21 15:12:27 API/INIT: creditcoin-node/222: Not decorating unknown runtime apis: TaskApi/1
Creating bond transaction...
Controller address: 5EEoJZYPpTYGX1t3shaQbqhRmqvdvoaTycY1gJ4TB8spDgPp
Reward destination: Staked
Amount: 1000005
✔ Continue? … yes
Extra: undefined
Bond transaction sent with hash: 0x66a41e3f1edd0bfcd43cd565a8b0c2f191856c79afd587c0fe4b04665c6786da
Overall looks good. Added a few comments.
atodorov
changed the title
atodorov
requested changes
Jun 21, 2023
I think I fixed all the issues. |
atodorov
approved these changes
Jun 21, 2023
AdaJane
approved these changes
Jun 21, 2023
dlebee
pushed a commit
that referenced
this pull request
Jun 22, 2023
* changed sensitive input to interactive or env vars * improved error handling in getSeedFromEnvOrPrompt * yarn format * eslint * changed prompt from invisible to password * centralized the regular seed * rectified stash vs bond key elicitation * set_keys actor rectification * make pretty * unbound to controller seed * appropriate names * prettify --------- Co-authored-by: Jon Zlotnik <jon.zlotnik@gluwa.com>
AdaJane
pushed a commit
that referenced
this pull request
Jun 26, 2023
* changed sensitive input to interactive or env vars * improved error handling in getSeedFromEnvOrPrompt * yarn format * eslint * changed prompt from invisible to password * centralized the regular seed * rectified stash vs bond key elicitation * set_keys actor rectification * make pretty * unbound to controller seed * appropriate names * prettify --------- Co-authored-by: Jon Zlotnik <jon.zlotnik@gluwa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: